Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need _validate_input()? #17

Open
mnlevy1981 opened this issue Sep 16, 2021 · 0 comments
Open

Do we need _validate_input()? #17

mnlevy1981 opened this issue Sep 16, 2021 · 0 comments

Comments

@mnlevy1981
Copy link

It looks to me like _validate_input() serves two purposes:

  1. Verify that objects in the collection are either a Dataset or a DataArray
  2. convert DataArrays to Datasets

The first task isn't necessary, since pydantic does this when we define self.dataset, and it's not clear to me why we want to do the second task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Xdev Project Board
Status: 🌳 Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnlevy1981