Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similarity to DataTree #67

Open
TomNicholas opened this issue Jun 8, 2022 · 4 comments
Open

Similarity to DataTree #67

TomNicholas opened this issue Jun 8, 2022 · 4 comments

Comments

@TomNicholas
Copy link

Hi @andersy005 - @jhamman showed me this repo earlier, and I've just had a look through it.

Obviously xcollection is similar to datatree, but the one-level dictionary-like design is also close to Arviz's InferenceData class (which datatree aims to replace, see arviz-devs/arviz#2015).

There are some things in xcollection that would be good inspiration for datatree, in particular:

Beyond those methods I think datatree supplants xcollection.

If anyone here is interested in contributing to datatree at all then that would be great! The idea is to build it out in xarray-contrib before merging it upstream into xarray.

@andersy005
Copy link
Member

andersy005 commented Jun 8, 2022

Beyond those methods I think datatree supplants xcollection.

@TomNicholas, this is 💯 right. We started working xcollection when datatree was still an idea. Once you began working on datatree, we slowed down on xcollection development since most of the features we wanted were going to be in datatree. I think the right thing to do is (1) join effort by helping you with the development of datatree, (2) deprecate/archive xcollection.

Ccing @ncar-xdev/xcollection for thoughts/feedback...

@mgrover1
Copy link
Contributor

mgrover1 commented Jun 8, 2022

@TomNicholas I would be interested in chatting soon. I am looking into using these hierarchal datasets with weather radar data in Py-ART, and have setup a prototype repo for exploration pyart-xarray-sandbox.

I tried both this xcollection and datatree approach which are almost identical, but would like to migrate towards datatree to collaborate with the rest of the Pangeo community. Do you have a place for "user stories" or "use cases"?

@TomNicholas
Copy link
Author

@mgrover1 that sounds great - please feel free to add anything you think might be useful as documentation to the DataTree repo. I think we should just collect useful resources for now and worry about the "right" place to put it later.

@mgrover1
Copy link
Contributor

mgrover1 commented Jun 8, 2022

Great! Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants