-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace submodule by jar inclusion to reference editorconfig-java #32
Comments
I agree in principle but last time I checked the editorconfig Java project will require adding OSGi manifest. The submodule is a hack but it is pinned to a commit id so it is not unsafe. |
MANIFEST.MF isn't necessarily. If we have it has a jar in a Maven repository, it's only a matter of:
|
OK that's great. I think the jar wasn't in maven central at the time I started this project. Using maven-dependency-plugin in pom to fetch it at build-timeAdding it to the build.properties to have it included in plugin jarAdding it to a Bundle-Classpath directive in editorconfig-eclipse to have it visible at runtime —You are receiving this because you commented.Reply to this email directly or view it on GitHub |
Apparently, it's still not published: editorconfig/editorconfig-core-java#6 |
@ncjones you might be interested in looking at ec4j [1] (a new .editorconfig Java parser) that was just released to central [2] [1] https://github.com/ec4j/ec4j |
Currently, the code copies the source of editorconfig-java to build. This is not safe because remote code can change and break the build. It seems better to consume directly the jar of a specific version using Maven.
The text was updated successfully, but these errors were encountered: