Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As you type validation inside editorconfig editor #35

Open
angelozerr opened this issue May 27, 2016 · 3 comments
Open

As you type validation inside editorconfig editor #35

angelozerr opened this issue May 27, 2016 · 3 comments

Comments

@angelozerr
Copy link
Contributor

The editorconfig editor should mark error when you are typing inside the editorconfig editor:

  • syntax error like section which are not closed.
  • semantic error like 'XXX' option name doesn't exists, or 'indenre t_style = 10' is false because indent_style waits for space or tab

To do that we need an editorconfig parser which is able to collect location offset where errors occur.

I had worked on this issue and pushed my work now. See https://github.com/angelozerr/editorconfig-java-parser

@angelozerr
Copy link
Contributor Author

@ncjones when you will have time, could you see https://github.com/angelozerr/editorconfig-java-parser please because I will use it to support validation and completion for the editor config.

I have copied/pasted your ConfigProperty., etc at https://github.com/angelozerr/editorconfig-java-parser/tree/master/fr.opensagres.editorconfig/src/fr/opensagres/editorconfig/model that I have updated to support validator and completion.

My idea is to provide features that IDE needs to integrate EditorConfig like validation, completion, and even a better support like https://github.com/editorconfig/editorconfig-core-java (don't reparse each .editorconfig content, use a real parser to extract pattern instead of using Regex, etc)

It should be very cool if you will be OK to move your classes into this project, hope you will like it.

@ncjones
Copy link
Owner

ncjones commented May 30, 2016

@angelozerr looks great!

I assume the duplicated code is temporary until your editor is contributed back to this project.

@angelozerr
Copy link
Contributor Author

angelozerr commented May 30, 2016

I assume the duplicated code is temporary until your editor is contributed back to this project.

No -(

My idea is to provide a Java toolings for .editorconfig which could work for other IDE like https://github.com/editorconfig/editorconfig-core-java have done, that's why I would like to know if you are OK to use classes from https://github.com/angelozerr/editorconfig-java-parser/tree/master/fr.opensagres.editorconfig/src/fr/opensagres/editorconfig/model and not yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants