Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with jquery 3.1.1? #42

Open
acarlson777 opened this issue Apr 3, 2017 · 7 comments
Open

Issues with jquery 3.1.1? #42

acarlson777 opened this issue Apr 3, 2017 · 7 comments

Comments

@acarlson777
Copy link

acarlson777 commented Apr 3, 2017

@nckprsn anyone having issues getting this to work with v.3.1.1? I'm acquiring the files just fine, but nothing is animating. I'm a little fresh to jquery so its possible I'm making some minor mistake in my html. I've required both the jquery library and the scroll me plugin in my head tag. And at the bottom of the body I have the $(function()){}); to load the script. But the div I have decked out with the data attributes wont animate. I have everything set to the same parameters that are applied to the Usage section on the demo page (the light gray code box on the right that fades and slides in from the right is exactly what I'm trying to emulate. If anyone might spare a minute to help an eager noob I'd greatly appreciate it. Thanks!
screen shot 2017-04-03 at 11 42 06 am
screen shot 2017-04-03 at 11 42 16 am

@ganimo
Copy link

ganimo commented Apr 7, 2017

I have the same problem. I think that is not compatible with jquery v.3.1.1. when I change to jquery v.2.1.1 work.

@joeyfromspace
Copy link

This is because scrollme uses $(window).load() which has been removed in jquery 3. It appears someone made a fork that addresses this here, though I've not tested the fix.

@subhasisghosal
Copy link

The fix is not working at all

@hicugi
Copy link

hicugi commented Feb 7, 2018

fixed:

replace on 123
// $window.load( function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) }); $(document).ready( function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) });

and on 447
// $document.on( _this.init_events.join( ' ' ) , function(){ _this.init(); } ); $('docuemnt').ready(function(){ _this.init(); });

@kylejcorrigan
Copy link

@hicugi fix works great! thanks!

@joekendal
Copy link

@hicugi have you tried making a PR?

@hicugi
Copy link

hicugi commented Jun 11, 2018

@joekendal PR? can you decipher?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants