Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with jquery 3.3.1 #54

Open
okbanouri opened this issue Jun 1, 2018 · 8 comments
Open

Doesn't work with jquery 3.3.1 #54

okbanouri opened this issue Jun 1, 2018 · 8 comments

Comments

@okbanouri
Copy link

okbanouri commented Jun 1, 2018

I had to use older jquery version (2.1.3) to make it work.

@bvrtsz
Copy link

bvrtsz commented Aug 21, 2018

Still not working for me. Created fresh new HTML test with only jquery 3.3.1 (2.1.3 works fine) and scrollme.js but it didn't help. No console errors, but styles are not apllied etc.

@joekendal
Copy link

@bvrtsz If there are no console errors then it's probably not an issue with the jQuery version. Could you share a code snippet so we can see where the issue may be

@bvrtsz
Copy link

bvrtsz commented Aug 21, 2018

@joekendal I've tried jQuery 2.1.3 with the same code and it's working perfectly fine.

God, damn, I cant upload my ocde here, just a minute.

https://codepen.io/anon/pen/LJEPVr

That's how my HTML looks like. Nothing fancy, just want to move the smaller square around.

I've got a "test" folder with html and scrollme.js

@joekendal
Copy link

@bvrtsz forked your code https://codepen.io/anon/pen/gdbYqP working

@andrey-prokhorov
Copy link

andrey-prokhorov commented Nov 27, 2018

@joekendal I forked https://codepen.io/anon/pen/gdbYqP and if you take latest verson from github "jquery.scrollme.min.js" - it stops working 😕

Strange that author does not put a version in the js file 😃

See example: https://codepen.io/andreyprokhorov/pen/pQZBYV
The diff: https://www.diffchecker.com/BmvCZpTM

@jasperuitterhoeve
Copy link

Is there a fix for this? I am having the exact same issue.

@sezaialkan
Copy link

Jquery 3.6.2

line 123 and
$window.on('load', function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) }); $(document).ready( function(){ setTimeout( function(){ _this.on_resize(); } , 100 ) });

change lines 447
$document.on( _this.init_events.join( ' ' ) , function(){ _this.init(); } ); $('document').ready(function(){ _this.init(); });

@joekendal
Copy link

Bro no one still uses jquery do they

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants