Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to display who posted question. and fix profile pics for questions and profile pages #34

Closed
tracey-le opened this issue Jan 24, 2017 · 17 comments
Closed

Trying to display who posted question. and fix profile pics for questions and profile pages #34

tracey-le opened this issue Jan 24, 2017 · 17 comments
Assignees
@tracey-le

Comments

@tracey-le
Copy link
Collaborator

tracey-le commented Jan 24, 2017 •
edited
Loading

oh, the other day I realised that we can't actually see who posted the question when you view one 🤔

screen shot 2017-01-24 at 9 25 08 pm
tracey-le added a commit that referenced this issue Jan 24, 2017
@tracey-le
Added basic username next to question, addressing #34
90dabcb 
Note to self: see `view.py` for valid var names for template language,
and see `view_question.html`
@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 24, 2017 •
edited
Loading

screen shot 2017-01-24 at 9 30 49 pm

added basically just username for minimum addressing of issue
  • can make it formatted and show profile pic and stuff

@tracey-le tracey-le mentioned this issue Jan 24, 2017
Closed
9 tasks
@tracey-le
Copy link
Collaborator Author

I stole the formatting for the comments

screen shot 2017-01-24 at 10 02 05 pm

please feel free to join:

  • can add unique formatting for user asking question but similar basic style to user posting comments

@tracey-le tracey-le self-assigned this Jan 24, 2017
tracey-le added a commit that referenced this issue Jan 24, 2017
@tracey-le
Threw in formatting for username and profile pic on view question pages
5ecb553 
I stole the formatting for the comments for now

see #34
@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 24, 2017 •
edited
Loading

I'm gonna leave that there (reaches bare minimum — you can view who posted a question now)

@tracey-le
Copy link
Collaborator Author

please feel very free to update the styling hehe

@tracey-le tracey-le reopened this Jan 24, 2017
@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 24, 2017 •
edited
Loading

I just realised that I think I got the wrong var — the username that shows up next to a post isn't the post creator, it's the user logged in 😂

@tracey-le tracey-le changed the title Can't see user who asked a question Username next to question should be question creator, not user logged in Jan 24, 2017
@tracey-le
Copy link
Collaborator Author

or maybe it's cos the question creators in the db were set to None? will make some more users to test and view

@tracey-le
Copy link
Collaborator Author

nah it's showing the username of the user logged in XD

tracey-le added a commit that referenced this issue Jan 24, 2017
@tracey-le
Fixed: question creator username now shows up next to post rather tha…
6723570 
…n user logged in

Latest issue in #34 fixed
@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 24, 2017 •
edited
Loading

now I should check that the profile pic is right (I'm guessing it's mixed up too :P)

I think next time i'll separate these into different, smaller issues

@tracey-le tracey-le changed the title Username next to question should be question creator, not user logged in Profile pic next to question should be of question creator, not user logged in Jan 24, 2017
@tracey-le
Copy link
Collaborator Author

it is mixed up, for comment posters too I think :P

@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 25, 2017 •
edited
Loading

@ninjaprawn Hi George 😊 I just have a question about the User class in the db_api

wait I had a better idea instead to ask — just wait a min

tracey-le added a commit that referenced this issue Jan 25, 2017
@tracey-le
Update db api documentation on user.edit and user.picture
aad11a0 
@ninjaprawn can you check these? :D
#34
@tracey-le tracey-le mentioned this issue Jan 26, 2017
Open
2 tasks
tracey-le referenced this issue Jan 28, 2017
@tracey-le
Trying to sort out profile pics for comments and profile page
b20682d 
- Added autofocus for signing page
- spaghetti code with profile pics for comments 😬😁👌🤞😛 here’s where
you hope nothing explodes 😂 it’s all good if it does tho 👍

- so while jumping from one problem to another, unearthing another
problem as I tried to do quick fix for another, this is what I’ve done.
for some reason I decided to add a profile_pic column to the comments
database (I think because it was complaining to me that I couldn’t
access `comment.user.picture` if the comment is empty when technically
it was created for no reason arrrgh hehe)

- so you can see it is all over the place XD but somehow it looks like
its working?? So okay, sure ill take that :P
@tracey-le
Copy link
Collaborator Author

I *think* this looks okay now, in #39

@tracey-le tracey-le mentioned this issue Jan 28, 2017
Merged
@tracey-le
Copy link
Collaborator Author

if there are any problems with using the changes I've made in here, like using get_user_picture(), please holler for me

@tracey-le
Copy link
Collaborator Author

@ninjaprawn I think I may have made things a little bit harder on your end in the db, with the stuff I did in here... 😅 😂 (hooray! gonna have merge conflicts and i've messed up the flow of how things worked too 😝)

@tracey-le tracey-le changed the title Profile pic next to question should be of question creator, not user logged in Trying to display who posted question. and fix profile pics for questions and profile pages Jan 28, 2017
@tracey-le
Copy link
Collaborator Author

Running into problems again 😔 XD

@tracey-le tracey-le reopened this Jan 28, 2017
@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 28, 2017 •
edited
Loading

Realised comment-problem branch was running an earlier version hence the same problems occurring.

  • will delete that outdated branch

@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 28, 2017 •
edited
Loading

theres a problem with profile pics not defaulting to 'mouser.png' if they have no pic. Ill just make a new issue

@tracey-le tracey-le mentioned this issue Jan 28, 2017
Closed
@tracey-le
Copy link
Collaborator Author

tracey-le commented Jan 28, 2017 •
edited
Loading

oh, this could still be enhanced with removing the outline around the user and their profile pic (remember, I 'stole' the formatting from the comments):

screen shot 2017-01-28 at 3 20 08 pm

tis a styling thing, I will leave this issue for now though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tracey-le tracey-le

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tracey-le