Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions report doesn't have users that using the Moodle mobile app #564

Open
bunkerskyi opened this issue Jan 16, 2024 · 6 comments
Open
Assignees
Labels
more information needed Need more information from user

Comments

@bunkerskyi
Copy link

Hello. We have problems, users who use the Moodle mobile app don't present in the Sessions report. I guess that happening because the join link in the mobile app doesn't have the uname parameter. Is that might be true?

I made this assumption, that the uname is critical, according to this comment and this PR

@bunkerskyi bunkerskyi changed the title Sessions report doesn't have users if they join from the Moodle mobile app Sessions report doesn't have users that using the Moodle mobile app Jan 16, 2024
@jrchamp
Copy link
Collaborator

jrchamp commented Jan 16, 2024

Thanks @bunkerskyi, we'll do some testing to see if we can reproduce the issue.

For any enterprising developer, here's the code flow:

Clicking the join meeting button in the Moodle Mobile app:

<ion-button class="ion-margin" expand="block" color="light" core-site-plugins-call-ws name="mod_zoom_grade_item_update" [params]="{zoomid: <% cmid %>}" [preSets]="{getFromCache: 0, saveToCache: 0}" (onSuccess)="loadMeeting($event)">

Calling the mod_zoom_grade_item_update function registered in services.php:

'mod_zoom_grade_item_update' => [
'classname' => 'mod_zoom\external',
'methodname' => 'grade_item_update',
'classpath' => 'mod/zoom/classes/external.php',

An external function provides the same join URL for Mobile, so it should already have the uname specified:

// Call load meeting function, do not use start url on mobile.
$meetinginfo = zoom_load_meeting($params['zoomid'], $context, $usestarturl = false);
// Pass url to join zoom meeting in order to redirect user.
$result = [];
if ($meetinginfo['nexturl']) {
$result['status'] = true;
$result['joinurl'] = $meetinginfo['nexturl']->__toString();

If the registered function returns success, a new window is opened using the returned join URL:

'javascript' => "this.loadMeeting = function(result) { window.open(result.joinurl, '_system'); };",

@jrchamp jrchamp added the more information needed Need more information from user label Jan 18, 2024
@jrchamp
Copy link
Collaborator

jrchamp commented Jan 18, 2024

Thanks @sgrandh3 for taking a look at this.

@bunkerskyi
Copy link
Author

@jrchamp Hello. I see more information needed badge on this issue. Please let me know if I can provide any additional info to speed up the process. We are very interested in solving this problem

@jrchamp
Copy link
Collaborator

jrchamp commented Feb 13, 2024

Thanks @bunkerskyi! I'm not sure exactly which part is not working, so it would be very useful for us to understand where it is breaking. Any help you can provide would be significant:

  1. Are you able to reproduce the issue yourself?
  2. Specifically, can you install the Moodle mobile app and the Zoom mobile app and join a meeting that someone else creates in Moodle?
  3. If so, does your name in the Zoom meeting show your Moodle user's name or does it show something else?
  4. After the scheduled task that loads the data for the sessions report is complete, does the report have the name that showed in the meeting?
  5. Which version of the mod_zoom plugin, Moodle Mobile app and Zoom mobile app are you using?

@sgrandh3
Copy link
Collaborator

sgrandh3 commented Mar 8, 2024

When tested, by hosting a zoom meeting as an instructor, to a student who logged from only mobile (disconnected from the browser) , i got 2 records of the student. Did it multiple times, with the same result. Adding the session report for reference.
zoom_participants_94832982546.xlsx

@jrchamp jrchamp assigned jrchamp and unassigned sgrandh3 Jul 18, 2024
@jrchamp
Copy link
Collaborator

jrchamp commented Jul 18, 2024

I noticed the same "2 records" behavior when I was verifying the bug reported in #601. We need to take a look at the API response to see what's happening there and make sure that we're accurately representing the data in Moodle. It might be unintentionally duplicated or it might just be the way that Zoom reports non-host participants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more information needed Need more information from user
Projects
Status: Needs triage
Development

No branches or pull requests

3 participants