Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The aria-label="*" and aria-hidden="true" attributes in the same svg element #33

Open
gyurmey2 opened this issue May 13, 2023 · 1 comment
Labels
Bug Something isn't working right.

Comments

@gyurmey2
Copy link

gyurmey2 commented May 13, 2023

Important. Applies to WP icons only (not custom icons).

aria-hidden="true" will hide the element completely to assistive technology. The element will not be in the accessibility tree (kind of like the DOM tree) so a screen reader user will not know the element is there. The aria-label="*" will be ignored because it's hidden.

Additionally, when we add a link without adding a label attribute, the aria attribute returns an empty string (for WP & custom icons).

@ndiego
Copy link
Owner

ndiego commented Jul 29, 2023

Thanks for reporting this issue @gyurmey2. I have looked into it and the aria-hidden="true" appears to be hardcoded in all Core icons and I have not been able to figure out a way to override this. I'll keep exploring a solution, but just wanted to provide an update.

@ndiego ndiego added the Bug Something isn't working right. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working right.
Projects
None yet
Development

No branches or pull requests

2 participants