Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Same presignature ID reused 80+ times in an hour to generate signature #924

Open
Tracked by #926
ppca opened this issue Nov 6, 2024 · 3 comments
Open
Tracked by #926
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda

Comments

@ppca
Copy link
Contributor

ppca commented Nov 6, 2024

log link
Basically from 8:31 am Nov 6 - 9:31 am Nov 6 PST, log entries for dev node 0 where the presignature_id = 9223372036854776000, has 89 times joining protocol to generate a new signature, and has 46 times completed signature generation.

This should not happen because we should not be reusing the presignatures at all.

Note, I did observe this in our system while I was debugging our system in May. This likely is not a recent issue.

@ppca ppca added Near BOS NEAR BOS team at Pagoda Emerging Tech Emerging Tech flying formation at Pagoda labels Nov 6, 2024
@ppca ppca changed the title Same presignature ID reused 80+ times in an hour to generate signature bug: Same presignature ID reused 80+ times in an hour to generate signature Nov 6, 2024
@volovyks
Copy link
Collaborator

And it is still there. This pre-signature is still being used to generate a signature.

@volovyks
Copy link
Collaborator

Something is wrong with our IDs. This ID has both a triple and a presignature, and they are constantly reused.

@volovyks
Copy link
Collaborator

@ppca please, check the PR, maybe it will shed some lite on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda
Projects
Status: Backlog
Development

No branches or pull requests

2 participants