Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "test-provider" Github Actions Test Conditional #2379

Closed
tylergraff opened this issue Apr 3, 2024 · 2 comments
Closed

Make the "test-provider" Github Actions Test Conditional #2379

tylergraff opened this issue Apr 3, 2024 · 2 comments

Comments

@tylergraff
Copy link
Contributor

Feature description

The "test-provider" Github Actions test fails when run from forks of this repo which do not have credentials set up to access the cloud providers used by the test. This situation generates CI/CD pipeline failure messages every time the test is run from such a fork.

I propose an "opt-out" repo-level configuration mechanism which instructs the Github Actions pipeline to skip this test.

Value and/or benefit

Being able to skip the "test-providers" (cloud platforms) test would allow maintainers of forks of this repo to avoid the CI/CD failure messages and emails which result from not having credentials set up. This would be especially useful for forks which do not have a budget to run these tests.

Anything else?

No response

@viniciusdc
Copy link
Contributor

Hi @tylergraff, This looks good. We can have the associated change merged, but I also think that maybe just skipping this whole test suite when not running from the upstream repository might be a good condition. These tests only attest that the CLI can be executed for our different providers, which for the forked repos can't be executed unless that maintainer adds cloud credentials.

Though, this discussion will be more fitting for #2382

@Adam-D-Lewis
Copy link
Member

I believe this was fixed by #2369. Feel free to reopen if something remains.

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants