Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Metadata options not applying #28

Open
imnotteixeira opened this issue Dec 9, 2020 · 0 comments
Open

Site Metadata options not applying #28

imnotteixeira opened this issue Dec 9, 2020 · 0 comments

Comments

@imnotteixeira
Copy link

imnotteixeira commented Dec 9, 2020

Hey there! Just stumbled upon this theme and I am really liking its features.

I was just looking at how I could change the topics that show up on the homepage like bloggers, geeks, nerds, people, everyone` and I noticed you mention on the docs I can pass siteMetadata on the gatsby-config. However, it's not taking effect.

I inspected the code and on the default gastby-config (on the theme), you don't take into account the themeOptions.siteMetadata, I added ...themeOptions.siteMetadata to the end of the default options directly on the theme's gatsby-config on node_modules and it worked, since it overrides any provided fields of siteMetadata available on the user's config, so I believe it should be added.

I'd like to know if I did something wrong, and it should work already, or what you think about the proposal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant