Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove window.__APOLLO_CLIENT__ assignment and use client from provided context #3

Open
pospi opened this issue Jan 31, 2023 · 0 comments
Open

Remove window.__APOLLO_CLIENT__ assignment and use client from provided context #3

pospi opened this issue Jan 31, 2023 · 0 comments
Labels
code quality Code quality / cleanup jobs (low priority)

Comments

@pospi
Copy link
Collaborator

pospi commented Jan 31, 2023

Some dirty workarounds are present here for apollo-elements/apollo-elements#274.
Once resolved we should update lit, remove direct assignment of window.__APOLLO_CLIENT__, and dynamically pass the client from element context into any ApolloController class constructors.
@pospi pospi added the code quality Code quality / cleanup jobs (low priority) label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code quality / cleanup jobs (low priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pospi