From 5eda246090b3721be5b0c1d08c6570b56605ac1c Mon Sep 17 00:00:00 2001 From: Martin Herndl Date: Tue, 24 Sep 2024 11:06:55 +0200 Subject: [PATCH] chore: fix ci (#2343) | Q | A | |---------------|---------------------------------------------------------------------------------------------------------------------------| | Bug fix? | no | | New feature? | no | | Deprecations? | no | | Issues | Fix #... | Trying to get a green build again. Apparently it started failing somewhen between August and September. Not checking in composer.lock is risky, especially with tooling like PHPStan this can break any time :/ also: composer.json says php >= 7.4 but there are PHP 8+ features in the code like named properties? --- .php-cs-fixer.dist.php | 1 + tests/Functional/ControllerTest.php | 11 ----------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php index b8e14f420..6f2414a32 100644 --- a/.php-cs-fixer.dist.php +++ b/.php-cs-fixer.dist.php @@ -20,5 +20,6 @@ file that was distributed with this source code. HEADER ], + 'trailing_comma_in_multiline' => false, ]) ->setFinder($finder); diff --git a/tests/Functional/ControllerTest.php b/tests/Functional/ControllerTest.php index 62db61d4b..0019cf36f 100644 --- a/tests/Functional/ControllerTest.php +++ b/tests/Functional/ControllerTest.php @@ -14,7 +14,6 @@ use OpenApi\Annotations as OA; use Symfony\Component\HttpKernel\Attribute\MapRequestPayload; use Symfony\Component\HttpKernel\Kernel; -use Symfony\Component\HttpKernel\KernelInterface; use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator; /** @@ -30,16 +29,6 @@ final class ControllerTest extends WebTestCase protected function setUp(): void { $this->configurableContainerFactory = new ConfigurableContainerFactory(); - - static::createClient([], ['HTTP_HOST' => 'api.example.com']); - } - - /** - * @param array $options - */ - protected static function createKernel(array $options = []): KernelInterface - { - return new NelmioKernel([], null, []); } protected function getOpenApiDefinition(string $area = 'default'): OA\OpenApi