Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to buy a domain that is already owned, still charges and burns gas #37

Open
amlwwalker opened this issue Sep 25, 2024 · 1 comment

Comments

@amlwwalker
Copy link

As shown here I attempted to buy the domain jamesbond.neo (yesterday)
image

However as this shows, this domain is already owned
https://explorer.onegate.space/transactionInfo/0xd983ae6179e2658473fd9e96a96d8869d45efb5fbbcba195c30234b6a2d236c4

and this is confirmed by the neo.link website

image

yet here we can see the attempt to buy this same domain and being charged for it
https://explorer.onegate.space/transactionInfo/0x30e4725a000478df0cb5dbe48c6f16174347b3ca658e06339d7ad993fedd39ed

Can the contract be updated so that it checks whether or not to burn the gas based on whether the domain is available? This seems very 'mean' on people who make a mistake....

@roman-khimov
Copy link

As @dusmart correctly pointed in neo-project/neo#3552 (comment) moving the burn call won't help, system fee has to have enough GAS for successful registration anyway and it won't be returned even if the contract doesn't burn its part of the fee (neo-project/neo#2806).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants