Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for neo4j-gremlin 3.4.8 #21

Open
kuzeko opened this issue Aug 25, 2020 · 9 comments
Open

Support for neo4j-gremlin 3.4.8 #21

kuzeko opened this issue Aug 25, 2020 · 9 comments

Comments

@kuzeko
Copy link

kuzeko commented Aug 25, 2020

Is neo4j-gremlin 3.4.8 supported yet? I cannot find in maven central the corresponding dependency
latest is 0.9-3.4.0 ?

@jexp
Copy link
Member

jexp commented Aug 30, 2020

You should be able to just update the dependency locally.

@kuzeko
Copy link
Author

kuzeko commented Aug 31, 2020

You mean I should change it in the pom and compile it locally?

@jexp
Copy link
Member

jexp commented Aug 31, 2020

Yes.

I can actually not remember, if it bundles neo4j jars or just links to them. In the latter case you should be able to just replace them with the newer version.

@kuzeko
Copy link
Author

kuzeko commented Aug 31, 2020

What if I do that and provide a pull request?

@jexp
Copy link
Member

jexp commented Aug 31, 2020

sure, go ahead. Thank you.

You will need to sign our CLA though https://neo4j.com/developer/cla

@kuzeko
Copy link
Author

kuzeko commented Sep 1, 2020

So I got this error while bulding:

Could not find artifact org.neo4j:neo4j-enterprise:jar:3.5.21 in central (https://repo.maven.apache.org/maven2)

So this means I need to access those jars locally somehow I guess...?

@jexp
Copy link
Member

jexp commented Sep 1, 2020

Yes since 3.5 the enterprise jars are no longer in maven central just in the binary distribution.

Also as HA has been removed from 4.0 onwards, I would say the best thing is to remove the Cluster/Enterprise bits from the code.

Customers/users that have access can put the dependencies in if needed.

@kuzeko
Copy link
Author

kuzeko commented Sep 1, 2020

Ok, so I cannot compile it?
I did a test and put there the latest 3.5-beta for the enterprise and it compiled.

Here I am working on the 3.5 branch yet, so I think HA can stay there

@kuzeko
Copy link
Author

kuzeko commented Nov 25, 2020

Hi, I have this pull request pending, but not sure how to fix it

#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants