Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spatial.importOSM() adds a layer when a file cannot be found. #383

Open
jamesdhope opened this issue Aug 7, 2021 · 0 comments
Open

spatial.importOSM() adds a layer when a file cannot be found. #383

jamesdhope opened this issue Aug 7, 2021 · 0 comments

Comments

@jamesdhope
Copy link

jamesdhope commented Aug 7, 2021

This is a minor suggestion but might make it less confusing working with the library:

Spatial.importOSM() adds a layer when a file cannot be found. Since there are no stats shown in the output on number of nodes added etc, it appears as if the layer have been imported successfully when it hasn't.

neo4j@neo4j> CALL spatial.importOSM("london.osm");
Failed to invoke procedure spatial.importOSM: Caused by: java.io.FileNotFoundException: london.osm (No such file or directory)
neo4j@neo4j> CALL spatial.importOSM("london2.osm");
Failed to invoke procedure spatial.importOSM: Caused by: java.io.FileNotFoundException: london2.osm (No such file or directory)
neo4j@neo4j> CALL spatial.layers();
+-------------------------------------------------------------------------------------------+
| name | signature |
+-------------------------------------------------------------------------------------------+
| "london.osm" | "EditableLayer(name='london.osm', encoder=GeometryEncoder(bbox='bbox'))" |
| "london2.osm" | "EditableLayer(name='london2.osm', encoder=GeometryEncoder(bbox='bbox'))" |
+-------------------------------------------------------------------------------------------+

3 rows available after 3 ms, consumed after another 2 ms
neo4j@neo4j>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant