Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpify --sdk #66

Open
esetnik opened this issue Jun 4, 2020 · 4 comments
Open

Support pnpify --sdk #66

esetnik opened this issue Jun 4, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@esetnik
Copy link

esetnik commented Jun 4, 2020

Pnpify documentation shows that prettier is supported https://yarnpkg.com/advanced/editor-sdks#vim--cocnvim but we need to add a custom prettierPath to the coc-settings.json so that the pnpified prettier can be used. Can coc-prettier add support for this? The vscode extension already supports it.

https://github.com/yarnpkg/berry/blob/8e77d191926e841faaf7093de24db0409e6094a7/packages/yarnpkg-pnpify/sources/generateSdk.ts#L172

@tlvince
Copy link

tlvince commented Jun 16, 2020

Related to neoclide/coc-tsserver#166; was about to post the same 👍

@mfzl
Copy link

mfzl commented Sep 1, 2021

Has this been solved or is there a workaround?

@chemzqm chemzqm added the enhancement New feature or request label Sep 2, 2021
@jackielii
Copy link

I think setting "prettier.prettierPath": ".yarn/sdks/prettier/index.js", in .vim/coc-settings.json works

@lyleunderwood
Copy link

The above did not work for me, as the SDK was attempting to import prettier from the zip file which threw an error. Try:

"prettier.prettierPath": "yarn exec prettier"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants