Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test that breaks on CI #54

Open
neocotic opened this issue Nov 23, 2018 · 2 comments
Open

Fix test that breaks on CI #54

neocotic opened this issue Nov 23, 2018 · 2 comments
Labels

Comments

@neocotic
Copy link
Owner

While running builds for 0.5.0 I noticed that one of the tests for the media-queries.svg fixture was failing, but only for PNG output and only on CI. Annoyingly, it was working fine locally for Node.js v8, v10, and v11, however, the CI job for Node.js v8 was the only one passing.

Tests for this fixture have been skipped for now as a temporary measure, however, I'd like to avoid doing this for obvious reasons and investigate the root cause.

I might see if I can spin up a Ubuntu Trusty (the version used by Travis) VM locally and try to replicate there as I'm on Ubuntu Cosmic and cannot replicate. I haven't tried in any other OS' though.

@neocotic neocotic added the build label Nov 23, 2018
@neocotic
Copy link
Owner Author

I just noticed that Ubuntu Xenial is now available on Travis, so I might try using that instead of Trusty to see if that has any affect.

@neocotic
Copy link
Owner Author

Moved away from Travis to GitHub workflows after they started demanding money. However, there are some tests still marked as skipped due to inconsistent results that should be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant