You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minecraft Version: 1.20.5 - 1.21.1. Tested using 1.21.1.
NeoForge Version: Tested using 21.1.61; should happen on any NeoForge with version in range [20.5.0, 21.1.61]
Logs: N/A, no crashes happen
Steps to Reproduce:
Create a low-code mod with only neoforge.mods.toml given below
modLoader="lowcodefml"loaderVersion="[1,)"license="CC0-1.0"
[[mods]] #mandatorymodId="test_description_with_single_quote"version="1.0.0"displayName="Test Description with Single Quote"description="It's regression time!"
Add it to your mods directory
Launch game
Open Mod List screen
Confirm that the low code mod is loaded by finding it on your left-hand side
Click the low code mod entry to open details
Find this line in your log, timestamp may vary:
[18:46:26] [Render thread/ERROR] [ne.ne.fm.i1.FMLTranslations/CORE]: Illegal format found `It's regression time!`
Description of issue:
Similar to #734, if mod description contains an apostrophe (U+0027 APOSTROPHE), ExtendedMessageFormat, which is used by FMLTranslations, will see it as unterminated quoted string and throw IllegalArgumentException.
It was fixed in #686 for 1.20.4, but the fix for 1.20.5 and onward - #851 - only covers mod name, not mod description.
Minecraft Version: 1.20.5 - 1.21.1. Tested using 1.21.1.
NeoForge Version: Tested using 21.1.61; should happen on any NeoForge with version in range
[20.5.0, 21.1.61]
Logs: N/A, no crashes happen
Steps to Reproduce:
neoforge.mods.toml
given belowmods
directoryDescription of issue:
Similar to #734, if mod description contains an apostrophe (U+0027
APOSTROPHE
),ExtendedMessageFormat
, which is used byFMLTranslations
, will see it as unterminated quoted string and throwIllegalArgumentException
.It was fixed in #686 for 1.20.4, but the fix for 1.20.5 and onward - #851 - only covers mod name, not mod description.
This regression was attested in Argon4W/EveryXHotpot@bb5458c.
The text was updated successfully, but these errors were encountered: