You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observe that the creative menu adds a second page with no extra tabs
Description of issue:
Neoforge expands the creative inventory screen to support more than one page of tabs, to support indefinitely many mods adding their own creative tabs. This is fine.
However, there is a discrepancy in how tabs are rendered:
When determining how many pages should exist, the number of tabs are counted (via CreativeModeTabRegistry.getSortedCreativeModeTabs(), regardless of their contents or visibility
When determining whether to render a given tab's... tab? The little clickable nubbins that switch to that tab, only tabs filtered by CreativeModeTab::shouldDisplay are rendered
This means that empty tabs (which can be empty for legitimate reasons, such as all of a mods' content being disabled by configs, or a mod creating a tab for datapacks and addons to add content to without adding anything itself) can inflate the page count and result in empty pages-of-tabs existing
Ordinary creative tab:
Empty creative tab: observe, page 2 still exists but is empty!
If there are a lot of empty tabs this can get increasingly absurd
The text was updated successfully, but these errors were encountered:
Minecraft Version: 1.21.1
NeoForge Version: 21.1.62
Logs: no logs
Steps to Reproduce:
Description of issue:
Neoforge expands the creative inventory screen to support more than one page of tabs, to support indefinitely many mods adding their own creative tabs. This is fine.
However, there is a discrepancy in how tabs are rendered:
This means that empty tabs (which can be empty for legitimate reasons, such as all of a mods' content being disabled by configs, or a mod creating a tab for datapacks and addons to add content to without adding anything itself) can inflate the page count and result in empty pages-of-tabs existing
Ordinary creative tab:
Empty creative tab: observe, page 2 still exists but is empty!
If there are a lot of empty tabs this can get increasingly absurd
The text was updated successfully, but these errors were encountered: