Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] EquipmentModelProvider methods should be changed to be more modid compatible #1842

Closed
Starexify opened this issue Jan 12, 2025 · 1 comment · Fixed by #1843
Closed
Labels
triage Needs triaging and confirmation

Comments

@Starexify
Copy link

Starexify commented Jan 12, 2025

Minecraft Version: 1.21.4

NeoForge Version: 21.4.51-beta

Description of issue:
The methods inside EquipmentAssetProvider should be made more modid dependent for mods to be able to generate the assets inside mod folder instead of vanilla or having to create a new method for it. As of now they are :

public static EquipmentClientInfo onlyHumanoid(String name) {
     return EquipmentClientInfo.builder().addHumanoidLayers(ResourceLocation.withDefaultNamespace(name)).build();
}

public static EquipmentClientInfo humanoidAndHorse(String name) {
     return EquipmentClientInfo.builder().addHumanoidLayers(ResourceLocation.withDefaultNamespace(name)).addLayers(LayerType.HORSE_BODY, new EquipmentClientInfo.Layer[]{Layer.leatherDyeable(ResourceLocation.withDefaultNamespace(name), false)}).build();
}

So I suggest providing a MODID field inside the EquipmentAssetProvider builder.

@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.4.56-beta, as part of #1843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triaging and confirmation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant