[1.21.5] [RFC] investigate what recipes we should patch to use c tags

[TelepathicGrunt]

NeoForge patches some recipes to use c tags so modded items works out of box for vanilla recipes.

Now the question becomes, how far do we want to go with these recipe patching?

Like milk bucket tag into cake?

What about iron ingot tags into all recipes that uses iron ingot?

Where should we draw the line?

[IchHabeHunger54]

In my opinion, yes, to the fullest degree that is reasonably possible. Anything where we do have a semantic replacement - ingots, nuggets, rods, etc. - should be replaced, because I really don't see a reason not to.

[Minecraftschurli]

we currently do the following replacements

• *_DYE -> dyes/*
• STICK -> rods/wooden
• GOLD_INGOT -> ingots/gold
• GOLD_NUGGET -> nuggets/gold
• IRON_INGOT -> ingots/iron
• IRON_NUGGET -> nuggets/iron
• NETHERITE_INGOT -> ingots/netherite
• COPPER_INGOT -> ingots/copper
• AMETHYST_SHARD -> gems/amethyst
• DIAMOND -> gems/diamond
• EMERALD -> gems/emerald
• COBBLESTONE -> cobblestones/normal
• COBBLED_DEEPSLATE -> cobblestones/deepslate
• STRING -> strings
• CHEST -> (chests/wooden - chests/trapped)

excluding packing recipes, white wool from string and stairs, slabs and walls for cobblestone and cobbled deepslate

[BarionLP]

the only problem i see is that this can be hard to prevent on the modders side. Lets say I have a special string. Some other mod uses the strings tag to do something with them that should also affect my string. But I don't want my string to be used as ingredient for wool (e.g. because I have my own fancy wool). I don't see a way for modders to prevent that. Of course the same problem will occur between mods but I don't think its a good idea to cause this problem on the modloader level.

An option would be to add some sort of replacement tags that clearly say that the item can be used exactly like it's vanilla counterpart.

[Minecraftschurli]

To clarify

1. This only affects vanilla recipes as we generate the replacements and include them in the neoforge jar
2. If you have a string and add it to the string tag you opt-in to it being treated the same as any other string