-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update angularfire2 to @angular/fire, getting rid of Angular 4 transitive dependencies #34
Comments
Here is a WIP (Work in Progress) fork: CsabaConsulting@fd2efa2 |
Issues in the WIP version:
|
I keep working on a fork off of the LA DevFest fork (https://github.com/CsabaConsulting/DeLorean-v2). The site does not throw such JS errors any more what triggered this issue, but still several parts don't work. We need help. |
@neojato can you take a look? |
Also note https://github.com/neojato/DeLorean-v2/tree/angularFire2-v5 |
We are having trouble getting the LA DevFest site running. In the past I just ignored the transitive unfulfilled Angular 4 npm dependencies, we are already on Angular 6.1.x+. However the LA DevFest throws JavaScript error.
Basically this would be a successor of the almost recent npm package updates, and we'd get rid of the
angularfire2/database-deprecated
imports in favor of@angular/fire...
.Expected Behavior
The project would use some more recent packages i some areas and the bootstrap of it would be even more robust.
Current Behavior
LA DevFest freshly forked website compiles, but JS error when site visited.
Possible Solution
Trying to run ahead and hoping that the upgrade would eventually solve the JS errors.
Steps to Reproduce
Context (Environment)
I can provide more details but it was reproduced both on Matt Kaufmann's machine + my machine, as well as at some point it rendered the live site inoperable. Fortunately we could roll back to the last working snapshot with Firebase hosting's features.
Details
angularfire2's obsolete dependencies:
The text was updated successfully, but these errors were encountered: