-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After resolved conflict, don't attempt to re-synchronise #3908
Comments
And there is a second similar case: If during publishing an error occurs, the editor can either abort fully or choose to resolve the conflict. Though one can definitely argue that the editor can if necessary just abort the publishing before resolving conflicts and then use the sync button separately ... though i think a 'Resolve conflicts' AND 'Resolve conflicts and continue publish' button makes sense. Either way we need a solution for the case that the attempted changes were discarded and the publish is now obsolete. With the Neos adjustments neos/neos-development-collection#5337 this can happen and throws an exception (especially in tests if the only change was dropped): Edit as we already have special handling in place ( neos-ui/packages/neos-ui-sagas/src/Publish/index.ts Lines 112 to 118 in f2526fd
|
While testing neos/neos-development-collection#5337 i found out through the e2e tests that the Neos Ui issues an obsolete call to rebase after the conflicts were resolved. Discarding or forcing a rebase does already rebase so a second rebase afterwards is obsolete, and will be handled more strictly with the core adjustments:
The error should be prevented client side by not calling the endpoint in this case.
The text was updated successfully, but these errors were encountered: