Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: default to log level "error" instead of "debug" #334

Open
justinmk opened this issue Mar 16, 2024 · 0 comments
Open

logging: default to log level "error" instead of "debug" #334

justinmk opened this issue Mar 16, 2024 · 0 comments
Labels

Comments

@justinmk
Copy link
Member

Problem

Currently we default to "debug" log level:

const level = process.env.NVIM_NODE_LOG_LEVEL || 'debug';

That seems a bit strange, it requires all consumers to undo that for production. Example:
https://github.com/vscode-neovim/vscode-neovim/blob/7592f1909467907da934e1748b1b7d5904dba67d/webpack.config.js#L50-L53

Expected behavior

Change default log-level. Update docs and possibly provide a warning during a "transitional" period.

@justinmk justinmk added the enhancement feature label Mar 16, 2024
@justinmk justinmk changed the title logging: default to log level "error" instead of "debug" by default logging: default to log level "error" instead of "debug" Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant