Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh:// github urls not supported #20

Closed
sbidoul opened this issue Jul 14, 2019 · 1 comment · Fixed by #26
Closed

ssh:// github urls not supported #20

sbidoul opened this issue Jul 14, 2019 · 1 comment · Fixed by #26
Labels
status: approved type: feature
Milestone
1.0

Comments

@sbidoul
Copy link

sbidoul commented Jul 14, 2019

Hi,

I noticed ssh:// urls are not recognized, such as ssh://[email protected]/Org/Repo.git.

I tried a PR but the current code structure does not make it very easy to support this properly and I ran out of time. Perhaps this could be taken into account in #10?

Thanks for this lib!
sbidoul added a commit to acsone/git-autoshare that referenced this issue Jul 14, 2019
@sbidoul
remove giturlparse dependency
2694896 
Our needs are simple enough.
See also nephila/giturlparse#20
@yakky
Copy link
Member

yakky commented Nov 15, 2020

@sbidoul thanks for reporting this, it will be fixed in #19

@yakky yakky added this to the 1.0 milestone Nov 15, 2020
@yakky yakky mentioned this issue Nov 21, 2020
Merged
2 tasks
@yakky yakky closed this as completed in #26 Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: approved type: feature
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Improve pattern recognition nephila/giturlparse
2 participants
@sbidoul @yakky