Add gen-kustomize-res #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fiachra Corcoran <[email protected]>
efiacor
requested review from
kispaljr,
vjayaramrh,
arora-sagar,
kushnaidu,
Catalin-Stratulat-Ericsson and
JamesMcDermott
This was referenced Jan 31, 2025
Closed
liamfallon
reviewed
Feb 4, 2025
liamfallon
reviewed
Feb 4, 2025
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/GoogleContainerTools/kpt-functions-sdk/go/fn" |
There was a problem hiding this comment.
Are these not in the kptdev project?
There was a problem hiding this comment.
Unfortunatley no.
https://github.com/GoogleContainerTools/kpt-functions-sdk
liamfallon
reviewed
Feb 4, 2025
| package main | ||
|
|
||
| import ( | ||
| "github.com/GoogleContainerTools/kpt-functions-sdk/go/fn" |
There was a problem hiding this comment.
Unfortunatley no.
https://github.com/GoogleContainerTools/kpt-functions-sdk
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** NOTE: **
Main review focus is on - https://github.com/nephio-project/nephio/pull/841/files#diff-29fd056fb0053f017fa95b29a5cacf982bbece2204a6c735297f99e20db258c1
80%+ code coverage from tests.
README - https://github.com/nephio-project/nephio/pull/841/files#diff-e1b41770c42c56af2ef1643ac198fe104b1e9917a426dc8783dd575fb20ca8c7
README Overview
...
Insert a Kustomize KRM, or if the resource already exists, update it's resources list to include the paths of all non local-config KRM resources. The function provides the ability to generate a kustomization.yaml, containing the KRM to be applied to a cluster by a gitops tool.