Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a Rdbms prototype repository for Porch #124

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

Implement a Rdbms prototype repository for Porch #124

wants to merge 48 commits into from

Conversation

liamfallon
Copy link
Member

No description provided.

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Oct 14, 2024
@liamfallon
Copy link
Member Author

/retest

@liamfallon
Copy link
Member Author

/retest

@nephio-prow nephio-prow bot added the approved label Oct 16, 2024
@liamfallon liamfallon changed the title Rdbms prototype Implement a Rdbms prototype repository for Porch Oct 23, 2024
@nagygergo
Copy link
Contributor

Could you add a makefile entry on setting up porch with a db repository

@liamfallon liamfallon force-pushed the rdbms-prototype branch 3 times, most recently from e152270 to 89a27f9 Compare November 4, 2024 16:39
@liamfallon
Copy link
Member Author

/retest

@liamfallon liamfallon force-pushed the rdbms-prototype branch 3 times, most recently from 4cfd557 to 844d9e8 Compare December 3, 2024 14:36
@liamfallon liamfallon force-pushed the rdbms-prototype branch 2 times, most recently from 82f08b3 to 24cdf07 Compare December 16, 2024 11:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 7, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2025
View reviewed changes
@liamfallon
Return pointer rather than instance on read of PackageRevision from db
f456ca4
@liamfallon
Fix up comments after rebase
1cb41f2
@liamfallon
Fix up comments after rebase
ceaa33d
@liamfallon
Update db repo due to rebases
31b5a4e
@liamfallon
Use a RDBMS as a cache in Porch
6086c2a
@liamfallon
Rebase against main
df3b66b
@liamfallon
rebase
55ef1cb
@liamfallon
Latest update
499a30d
@liamfallon
Tutorial update
d05efe5
@liamfallon
Correct trace statement
4318af0
@liamfallon
Added handling for resources
eca436f
@liamfallon
Updated to handle subpackages
ea31b74
@liamfallon
Clean up lint flags
259b357
@liamfallon
Refactored code to put repository implementations and cache implement…
883ed32 
…ations behind interfaces
@liamfallon
Cache moved behind interfce
cffb7e2
@liamfallon
Rebasing
1f581a7
@liamfallon
Up[date go modules
1d07598
@liamfallon
Refactoring to make db cache optional
a6a0c63
@liamfallon
Updated to fix 323 tests
46b2ca1
@liamfallon
Fix linting warnings
d5a7374
@liamfallon
Add command line options to enable db cache
ede953c
@liamfallon
Correct the names of some files and fix commetns in CR Cache
023cea1
@liamfallon
Fix mutex locking on package
6aabb03
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Feb 24, 2025

@liamfallon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-nephio-go-test 75ea664 link true /test presubmit-nephio-go-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nagygergo
nagygergo reviewed Feb 25, 2025
View reviewed changes
pkg/cache/dbcache/dbpackagerevisionsql.go
}
}

func pkgRevDeleteFromDB(prk repository.PackageRevisionKey) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a single transaction?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagygergo nagygergo nagygergo left review comments

@efiacor efiacor Awaiting requested review from efiacor

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamfallon @nagygergo