Fixed bug that prevented the Blender dataset from being loaded in gaussian splatting. #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pa-la
changed the title
|
#2704 could you please check that this PR also works? I think I fixed the same thing but with fewer changes, thanks! |
|
Closing this for now since I think #2704 fixes this, it also adds background color support in splatfacto. Feel free to re-open if there's still issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images from the Blender dataset do not have any distortion. The current code skips images for which distortion parameters are absent, which causes no image to be loaded at all.
Instead, when the distortion parameters are absent, we load the image and we skip the un-distortion part.