-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gaussian splatting support for Aria #2785
Conversation
undist_h = 500 | ||
undist_w = 500 | ||
undist_K = torch.eye(3) | ||
undist_K[0, 0] = 150.0 # fx | ||
undist_K[1, 1] = 150.0 # fy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seems pretty small from a quick eye glance! is this just hardcoded here for testing/prototyping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not come from the camera calibration itself so it would work for various Aria recording data profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, isn't it weird for these to be hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this was test code; I added some heuristics for computing this automatically! Not sure if there's a better way...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM and glad it was not too much surgery to get it working! Only real Q is about the choice for undistortion parameters (hardcoded vs programmatic). Note that not all Aria profiles have the same resolution for the RGB camera
88f9f04
to
d1783df
Compare
Thank you for fixing the masks in GS! d1783df LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* Gaussian splatting support for Aria * Respect masks in splatting loss function
Added support for the Fisheye624 model in the full image dataloader. @kerrj can you check if my changes make sense?
ns-process-data aria
now also saves the Aria MPS points, which seems to improve results slightly.Without points:

With points:

(this is the same capture as in #2617)
FYI @sweeneychris