Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian splatting support for Aria #2785

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Gaussian splatting support for Aria #2785

merged 10 commits into from
Jan 19, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Jan 18, 2024

Added support for the Fisheye624 model in the full image dataloader. @kerrj can you check if my changes make sense?

ns-process-data aria now also saves the Aria MPS points, which seems to improve results slightly.

Without points:
aria_without_points

With points:
aria_with_points

(this is the same capture as in #2617)

FYI @sweeneychris

@brentyi brentyi requested a review from kerrj January 18, 2024 08:40
Comment on lines 385 to 389
undist_h = 500
undist_w = 500
undist_K = torch.eye(3)
undist_K[0, 0] = 150.0 # fx
undist_K[1, 1] = 150.0 # fy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seems pretty small from a quick eye glance! is this just hardcoded here for testing/prototyping?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not come from the camera calibration itself so it would work for various Aria recording data profile

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, isn't it weird for these to be hardcoded?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this was test code; I added some heuristics for computing this automatically! Not sure if there's a better way...

Copy link
Contributor

@sweeneychris sweeneychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM and glad it was not too much surgery to get it working! Only real Q is about the choice for undistortion parameters (hardcoded vs programmatic). Note that not all Aria profiles have the same resolution for the RGB camera

@brentyi
Copy link
Collaborator Author

brentyi commented Jan 19, 2024

Thanks for the feedback everyone! I added logic for computing the undistorted camera parameters, and fixed some issues with the masks.

Some more results:
image

The results look cleaner now:
image

With initialization points (filtered from MPS) overlayed:
image

@f-dy
Copy link
Contributor

f-dy commented Jan 19, 2024

Thank you for fixing the masks in GS! d1783df LGTM!

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kerrj kerrj merged commit 6389cac into main Jan 19, 2024
4 checks passed
@kerrj kerrj deleted the brent/aria_gsplat branch January 19, 2024 19:09
@brentyi brentyi mentioned this pull request Jan 22, 2024
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
* Gaussian splatting support for Aria

* Respect masks in splatting loss function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants