Disable projectaria tools on Windows #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
approved these changes
Jan 19, 2024
ArpegorPSGH
pushed a commit
to ArpegorPSGH/nerfstudio
that referenced
this pull request
Jun 22, 2024
* Update pyproject.toml to work for windows again * Actually pycolmap works now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
projectaria-toolspackage doesn't have Windows binaries, which preventspip install -e .[dev]from working. I've updated the specification to require a platform other than Windows for installation. I also updated the specification to not use[all]after a discussion with the library authors, and fixed an underscore typo which was probably being silently transformed bypip.Previously (#2672), I had also disabled
pycolmap, but it turns out that very recently (as of Jan 11), there's now Windows wheels published forpycolmapon PyPi (https://pypi.org/project/pycolmap/#files), so it actually installs just fine. I also posted about that in the associated issue (#1480) in case someone wants to pick up the task to enablepycolmapusage again.