Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache header validation point (in case of crash) #4518

Open
Matt-RUN-CKB opened this issue Jul 16, 2024 · 4 comments · Fixed by #4742
Open

Cache header validation point (in case of crash) #4518

Matt-RUN-CKB opened this issue Jul 16, 2024 · 4 comments · Fixed by #4742
Assignees
@eval-exec
Labels
m:sync module: ckb-sync stale To be closed due to a lack of activity t:enhancement Type: Feature, refactoring.

Comments

@Matt-RUN-CKB
Copy link

Feature Request

Is your feature request related to a problem? Please describe.

When using CKB with assume_valid, currently the header verification always starts at block 0. In the case of a crash, header validation begins at block 0 again

Describe the solution you'd like

While header validation is ongoing, cache in the ckb node the latest header that has been verified, so in the case of a crash the node can start at the latest point
@Matt-RUN-CKB Matt-RUN-CKB added the t:enhancement Type: Feature, refactoring. label Jul 16, 2024
@eval-exec eval-exec added the m:sync module: ckb-sync label Jul 16, 2024
@eval-exec
Copy link
Collaborator

Great idea! As the number of blocks increases, the time consumed by Header Sync is also increasing significantly. CKB is planning to use the Light Client protocol to replace the Header Sync process to address this issue.

@eval-exec eval-exec self-assigned this Jul 16, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale To be closed due to a lack of activity label Dec 5, 2024
@eval-exec eval-exec mentioned this issue Dec 8, 2024
Merged
@eval-exec eval-exec removed the stale To be closed due to a lack of activity label Dec 11, 2024
@eval-exec
Copy link
Collaborator

I think we need to persist the headermap data before shutting down CKB. @zhangsoledad @quake

@eval-exec eval-exec reopened this Jan 9, 2025
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale To be closed due to a lack of activity label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eval-exec eval-exec

Labels
m:sync module: ckb-sync stale To be closed due to a lack of activity t:enhancement Type: Feature, refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend the hardcoded assume_valid_target to an array. eval-exec/ckb
2 participants
@eval-exec @Matt-RUN-CKB