You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In run_add_features.py I noticed that "in_protected_area" can be True or None for England and Wales, but True or False for Scotland.
This means in calculate_suitability.py that the not_in_protected_area_score isn't working as it should for Nulls. An example of this is below (I'd expect the nulls should get a score of 1):
I noticed this in investigating why Scotland seemed to have higher scores for HN's across the board - it seems like some of the LSOAs in England and Wales aren't getting the points for not being in a protected area.
Not sure where the best fix to this would be - in generate_df_uprn_in_cons_area maybe?
The text was updated successfully, but these errors were encountered:
In
run_add_features.py
I noticed that "in_protected_area" can be True or None for England and Wales, but True or False for Scotland.This means in
calculate_suitability.py
that thenot_in_protected_area_score
isn't working as it should for Nulls. An example of this is below (I'd expect the nulls should get a score of 1):I noticed this in investigating why Scotland seemed to have higher scores for HN's across the board - it seems like some of the LSOAs in England and Wales aren't getting the points for not being in a protected area.
Not sure where the best fix to this would be - in
generate_df_uprn_in_cons_area
maybe?The text was updated successfully, but these errors were encountered: