Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set in_protected_area to True or False (no none) #116

Closed
lizgzil opened this issue Jan 24, 2025 · 0 comments · Fixed by #117
Closed

Set in_protected_area to True or False (no none) #116

lizgzil opened this issue Jan 24, 2025 · 0 comments · Fixed by #117

Comments

@lizgzil
Copy link
Collaborator

lizgzil commented Jan 24, 2025

In run_add_features.py I noticed that "in_protected_area" can be True or None for England and Wales, but True or False for Scotland.

This means in calculate_suitability.py that the not_in_protected_area_score isn't working as it should for Nulls. An example of this is below (I'd expect the nulls should get a score of 1):

Image

I noticed this in investigating why Scotland seemed to have higher scores for HN's across the board - it seems like some of the LSOAs in England and Wales aren't getting the points for not being in a protected area.

Not sure where the best fix to this would be - in generate_df_uprn_in_cons_area maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant