Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CidrPrefix config parameter to support IP range(s) #110

Open
zolug opened this issue Nov 17, 2022 · 1 comment
Open

CidrPrefix config parameter to support IP range(s) #110

zolug opened this issue Nov 17, 2022 · 1 comment
Assignees

Comments

@zolug
Copy link

zolug commented Nov 17, 2022

Currently a network has to be specified that the provided IPAM will assign addresses from.
Besides using a whole network it could be beneficial if the address pool could be configured by defining an IP range or IP ranges.

Such feature would greatly complement networkservicemesh/sdk-vpp#634.
E.g. let's consider two independent NSM services provided by two separate Remote VLAN NSEs using the same VLAN ID and master interface and "sharing" the same network. To avoid duplicated IPs the network could be split into IP ranges distributed between NSEs.

@denis-tingaikin
Copy link
Member

@zolug, to separate two ippools could be used, exclude-prefix mechanics.

Currently, we have two fields that we designed for these cases.

  1. https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/connectioncontext.proto#L69
  2. https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/connectioncontext.proto#L73

So we probably could re-use https://github.com/networkservicemesh/sdk/tree/main/pkg/networkservice/common/excludedprefixes to solve the problem

OR we could implement a chain element for extra-exclude-preofix requests https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/connectioncontext.proto#L73

Feel free to share ur thoughts and correct me if I get something wrong :)

/cc @edwarnicke

nsmbot pushed a commit that referenced this issue Jan 23, 2023
This PR syncs files with https://github.com/networkservicemesh/cmd-template

Revision: https://github.com/networkservicemesh/cmd-template/commits/45507f606ec3c5ef9a742a4a6cc98da3bb2e1578

commit 45507f606ec3c5ef9a742a4a6cc98da3bb2e1578
Author: Ruslan Bayandinov <[email protected]>
Date:   Mon Jan 23 15:35:44 2023 +0700

    Fix deprecated Github Action set-output (#110)

    Signed-off-by: Ruslan Bayandinov <[email protected]>

    Signed-off-by: Ruslan Bayandinov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants