Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not push updates to deployments-k8s if cmd-* has been not changed binary #62

Open
denis-tingaikin opened this issue Feb 22, 2021 · 1 comment
Open

Do not push updates to deployments-k8s if cmd-* has been not changed binary #62

denis-tingaikin opened this issue Feb 22, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@denis-tingaikin
Copy link
Member

Issue

cmd-* repos push updates into deployments-k8s repo even if they haven't changed binary.

Actual: NSMBot always update deployments-k8s repo
Expected: Do not update deployments-k8s repo if the change doesn't change behaviour of the application.

Solution

Compare the new version with the latest version from networkservicemeshci on docker-push and do not push new version if there no binary changes.
@denis-tingaikin denis-tingaikin added bug Something isn't working enhancement New feature or request labels Feb 22, 2021
@denis-tingaikin denis-tingaikin changed the title Do not push updates to deployments-k8s if command has been not changed binary Do not push updates to deployments-k8s if cmd-* has been not changed binary Feb 22, 2021
@edwarnicke
Copy link
Member

This is very interesting... how would we do the comparison?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwarnicke @denis-tingaikin