Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address architecture proposal conflict in social architecture process #5

Closed
TimDaub opened this issue May 27, 2022 · 2 comments
Closed

Comments

@TimDaub
Copy link
Contributor

TimDaub commented May 27, 2022

@il3ven and I do have different opinions when it comes to the strategies architecture:

Conflict:

  • @il3ven's point is that it's hard to understand for an outsider that there's e.g. a convention to e.g. pass return { write: "string" }
  • My point is that e.g. currently we can't focus on improving aesthetics because we have to ship for e.g. Hifilab's music-os.
  • Another one of my points is that e.g. a code's correctness trumps its interface's aesthetic.

Partially, some of those values are already present in the social architecture. For e.g. we say that:

Simplicity: A design must be simple, both in implementation and interface. It is more important for the interface to be simple than the implementation [4].

Correctness: A design must be correct in all observable aspects. Incorrectness is simply not allowed

Consistency: The design must not be overly inconsistent. Consistency can be sacrificed for simplicity in some cases [4].

So e.g. I'm rejecting @il3ven's proposal on the following points:

  • The current architecture in the main branch works. It is correct - that's the most important thing about the implementation
  • It's unclear if @il3ven's proposal will be correct too, e.g. check once function comment
  • Finally; we're ok with compromising on consistency for simplicity. We're not OK with compromising simplicity for correctness.

IMO, I've validly represented the guidelines in the social architecture document. @il3ven would you agree that I've validly represented them? If yes, do you think these social architecture principles reflect your preferences for creating software? How could we improve them to include your principles too?

Additionally, there's #6

@il3ven
Copy link
Contributor

il3ven commented May 27, 2022

would you agree that I've validly represented them

Yes, the social architecture correctly captures the guidelines. I agree on the guidelines. 😅

@TimDaub
Copy link
Contributor Author

TimDaub commented May 27, 2022

fine, then I'm closing

@TimDaub TimDaub closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants