-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: weird triland shape after signing in from screen lock #77
Comments
Hello, Ah, looks like an error occurred while disabling the extension. Gnome disables the extension on Screen Lock and enables on Unlock. I will look into it. If you logout and log back in, the error and issue should go away. Something like this was reported in another extension as a one-off so that's what I expect here too. But need to figure out the root cause.
Thanks for reporting! |
here is the log.
I can reproduce it every time.
Yes. |
Thank you for the log! I wasn't still able to recreate it using the Screensaver command here on Ubuntu and Fedora but got a fair idea about what maybe causing the error. I have added a fix to the Let me know if the fix works for you. |
I have added a fix to this issue in GitHub
I did not understand the alpha part. In case, it is still an issue, please elaborate on what exactly happens with it, maybe some screenshot. You can get the updated extension here - openbar@neuromorph You will need to log out and log back in after the change. Let me know if it works. |
Oh crap, the crash. It looks like issue #63 . Anyway, we will need to confirm the stack trace to make sure it is the same issue. To get the stack trace:
In the crash log, I search for 'neuromorph', 'openbar', 'stylesheet' or the typical candidate in this issue 'st_theme_node_lookup_shadow' to find relevant part. One thing I noticed is that the issue was not happening on Disabling the extension but happened on screen lock/logout which also leads to Disable being called by Gnome. The difference is that on lock/logout, the Panel is changed by Gnome and most widgets are removed except Quick Settings. This happens in parallel as OpenBar is also removing its styles/changes as required to be done on Disable and somehow a situation is created that triggers the underlying upstream bug. One more thing you could try is to add 'unlcok-dialog' session to OpenBar so it can run on Lock screen. The trouble is that, even if it is marked to run on Lock screen, Gnome still disables it (potentially many times) and enables it again as part of their rebasing algorithm. Anyway, to do this, you will need to add an entry to the Lets see what all info we can gather, I will keep looking for the solution accordingly. Thanks! |
Update: I have changed the way Trilands is implemented in an attempt to avoid the crash scenario. This might solve it. Let me know if that works for you. |
Finally it crashed, (I didn't install your latest commit), it is still caused by a screen unlock.
17:05 should be the time when I tried to unlock and I'll try your latest git from now. |
This log does not have any crash report. With This log does have an error though wherein it failed to reload the stylesheet. It complains that the runtime directory where the stylesheet resides is undefined while it gets defined during extension 'enable'. I will have a look into it.
Yeh, try with that. Let me know if you face any error or crash. Especially, if you could reproduce it earlier then try to do it with this new version. Lets hope it works OK. Thanks! |
it crashes again with the latest git version, here is the log from
I'll switch to island mode temporarily and hope I won't get crashed. Feel free to let me know if you need more logs or help. |
This is indeed the same crash from the upstream Gnome/Mutter issue mentioned earlier. I tried many tricks to avoid it since it seems to appear only for specific bar types (mainly Trilands and Candybar) but evidently it did not work. And since there are tons of different configs/setups that people use, I haven't been able to reliably reproduce it in VMs. BTW, my main system is on Ubuntu. The MR I mentioned earlier for the upstream bug, was raised by an Ubuntu developer and they confirmed that they have already merged it in Ubuntu and possibly why I am not facing the crash at all on this system. The other extensions you have should not ideally cause an issue but you could try by disabling all and only enabling OpenBar and then see if you can reproduce the crash. Also another thing, as mentioned earlier, is to add 'unlcok-dialog' session to OpenBar. See if that helps to avoid the crash. Let me know if any updates. |
Hello, I am also experiencing this issue where using Open Bar with the trilands configuration causes a crash after logging in from a hybernation. I'm on Fedora 40 and Gnome 46. I have confirmed this by disabling all other extensions except for Open Bar. Using other bar styles prevents crashes. I haven't tried running with the link you provided, but I plan to. Just to confirm, I do this by copying/replacing the files in /~/.local/share/gnome-shell/extensions/openbar@neuromorph (or wherever it's installed)? |
Hello,
That is unfortunate! There is an upstream bug mentioned in a comment above. There is also a MR linked there. It was raised by an Ubuntu developer and has been merged in Ubuntu but Gnome/Mutter for some reason have not added any fix. The reason could be that the default Gnome does not does not face this issue currently. From the linked issue and MR what I understand is that on lock/suspend/hibernate when Gnome disables the extensions, their stylesheets are unloaded and in some cases old references remain in the cache pointing to old/invalid memory locations resulting in a segfault. The MR tries to clean it up and seems to be working since I am not facing any crash on Ubuntu.
Yes, do try the version from GitHub to see if it helps. It also has some other minor fixes that will land in the next update.
Correct, just download the files from GitHub and replace your local install at that location. You will need to logout and log back in for the new files to take effect. Thanks! Edit: I just thought of something else I could do. Let me know how the current GitHub version works out and in couple days I will try to push the next (maybe last) possible attempt to get around it locally (until upstream fix gets added) 🤞 |
I have added another update to the same location in GitHub. This time I am trying a different way to avoid the crash for Trilands. Please try it out and let me know. It is only for Trilands, so keep Candybar off. The Candybar style classes will still be added to the stylesheet but will be empty. If issue persists, I might try to remove them altogether to isolate the test for trilands. There are also some minor things to iron out (mainly for Neon border) in this version but it can be done later if it helps at all. Let's see if that helps. |
Hi @neuromorph , apologies for the delayed response. I actually thought I sent a follow-up already, but it looks like I didn't 😅 |
Yeh, I was looking forward to hear back from you guys. The previous version went other way round, moving mostly from js to stylesheet. If the previous version worked, that would be good as well at least for Trilands. The commit corresponding to it is - c366570 If I get some confirmation on if it does solve the issue for Trilands then I will push the next update with it. I am also trying to see if I can recreate the crash using a Fedora in VM. Thanks for getting back. You can try to revert to previous version from the commit and see if that helps. |
Just confirmed that the previous commit works by replacing the new files with the ones from c366570 😺 @neuromorph |
Unfortunately, after applying c366570 and enabling triland for a few days, gnome-shell just crashed again. |
Describe the bug
weird triland shape after signing in from screen lock
To Reproduce
Relevant Specs:
Screenshots
The text was updated successfully, but these errors were encountered: