Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Desktop Background Color Palette is inconsistent with the wallpaper(theme) switched by Night Theme Switcher #79

Open
xcpky opened this issue Oct 1, 2024 · 6 comments

Comments

@xcpky
Copy link

xcpky commented Oct 1, 2024

Describe the bug
After night theme switcher switch the theme, the wallpaper changes, but the openbar doesn't update Desktop Background Color Palette.
I've enabled all the autos.

To Reproduce
Steps to reproduce the behavior:

  1. night theme switcher switch the themes and wallpaper

Relevant Specs:

  • Open Bar version: 41
  • Gnome version: 47
  • OS/Distribution: archlinux
  • Other installed extensions if interference is expected [Optional]: night theme swticher
@neuromorph
Copy link
Owner

Hello,

I just tried with Night Theme Switcher. It basically changes the Dark/Light mode as per set time. If you have different wallpapers set for Dark/Light then the wallpapers will also change. OpenBar does change the color palette accordingly as well.
Demo tried with Fedora 41 in VM

One thing to note, both Dark/Light mode background images should be set when you click on Apply Autotheme in OpenBar. Basically, when OpenBar computes autotheme, it does so for both the backgrounds (if available) and saves them, and then when only the mode changes, it will switch the style/colors accordingly. The autotheme is recomputed when background changes but not recomputed when only the mode changes from Dark to Light or vice versa.

If you have kept, "Auto Refresh theme on background change" then it should recompute theme when you set new backgrounds (for both Dark and Light).

Let me know what exactly are you facing.

Thanks for reporting!

@xcpky
Copy link
Author

xcpky commented Oct 2, 2024

it seems this is the process to reproduce:

  1. enable night theme switcher
  2. at night, the gnome is in dark theme
  3. screen locks
  4. the next morning, when I log back in from screen lock, the theme and wallpaper is switched to light theme, but the color palette is not updated.

@neuromorph
Copy link
Owner

OK, that's why!

On lock screen OpenBar gets disabled so it does not know when the Dark/Light mode or wallpaper has been changed by Night Theme switcher.

I will look into a workaround to check if that's the case when OpenBar is enabled.

@neuromorph
Copy link
Owner

I have added a fix to this issue in GitHub main branch. You can get the updated extension here - openbar@neuromorph
Please install manually from there - (replacing extension.js and stylesheets.js should do)

You will need to log out and log back in after the change.

Let me know if it works.
Thanks!

@neuromorph
Copy link
Owner

This is released in the new version (OpenBar 42) out recently. Please try the latest update and let me know.

Thanks.

@xcpky
Copy link
Author

xcpky commented Dec 31, 2024

I am not using openbar now because of some reasons so for now i cannot test it, but i may come back later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants