Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Modal not large enough by default #98

Open
QuentiumYT opened this issue Dec 27, 2024 · 4 comments
Open

[BUG]: Modal not large enough by default #98

QuentiumYT opened this issue Dec 27, 2024 · 4 comments

Comments

@QuentiumYT
Copy link

Describe the bug
When opening the extension's settings, the modal width is not large enough, requiring to always enlarge it or make it full screen. Can it be adjusted so it'll fit better? It should be like 1000px wide at least.

Relevant Specs:

  • Open Bar version: 42
  • Gnome version: 47.0
  • OS/Distribution: Ubuntu 24.10

Screenshots
image
image

@neuromorph
Copy link
Owner

Oops, that's a bug. A change was made in the latest version to accommodate for low resolution screens and it seems to have broken it.

Please let me know your screen resolution and display scaling factor.

Thanks for reporting!

@QuentiumYT
Copy link
Author

Oh alright, yeah I saw the code, smart thing to adapt to the screen resolution.

I have a laptop with a 2560x1600px with a scale factor of 100%.
Also, I have the accessibility setting "Large text" that makes it like twice bigger, which correspond to the default text scale of Ubuntu.

Don't hesitate to ask me to test the extension before a release or if you are not sure it will fit, a large resolution is not so common I guess.

@neuromorph
Copy link
Owner

Also, I have the accessibility setting "Large text" that makes it like twice bigger,

This is probably causing the issue.

Your display is high-res but it also seems to be the trend now. On the other hand there is another issue opened in parallel where they are facing issue due to low res display of 768px :) , so it is a tug of war :p

I had kept it Gtk only to support Gnome 42 but may have to rewrite into Adwaita which is more responsive. However, that is considerable effort for which I don't have the bandwidth currently. I will see what can be done in a more immediate timescale.

Meanwhile, feel free to increase the width in prefs.js for your local install to avoid text getting cut.

@QuentiumYT
Copy link
Author

Alright, looks like it was this issue. I explored a little bit because I did some tests with another screen as well and I just reset the scale factor to 1 (1.01 actually, else Ubuntu set it back to 1.25) and increased only the built-in screen to 125%

image
I had to enable Fractional Scaling tho for people interested. So the text is no longer bigger on every screen now which is more logic as well :) Thanks for the investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants