Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lineedit (hand labeler & others) text entry focus issues #2989

Closed
stinkysmellystinkysmelly opened this issue Feb 27, 2025 · 1 comment
Closed

Comments

@stinkysmellystinkysmelly

I wrote the below before realizing this is fixed in vanilla/upstream: space-wizards/space-station-14#34621

So probably none of the below is necessary reading.

Description

Using a hand labeler, the text entry box in the pop-up window is selected / active without any additional input (or appears to be)
The result of this is that instead of one click being needed in order to activate and begin typing in the text entry box, two clicks are needed.

Reproduction

  1. Hold a hand labeler in your active hand
  2. Activate the labeler (or click on it)
  3. Observe the text entry box appears as though you could type in it, though since the popup window does not have the keyboard input, typing does not result in text entry
  4. Click inside the text entry box
  5. Keyboard input is still not accepted in the text entry

Expected Behavior
Option 1:

  1. Hold a hand labeler in your active hand
  2. Activate the labeler (or click on it)
  3. Text entry box appears unselected
  4. Click inside the text entry box to focus the window & focus the text entry
  5. Keyboard input is accepted in the text entry
    The advantage here being that user input like changing hands or movement wouldn't be affected, though the value of this with the hand labeler is questionable.

-OR-

Option 2:

  1. Hold a hand labeler in your active hand
  2. Activate the labeler (or click on it)
  3. Text entry box appears selected
  4. Keyboard input is accepted in the text entry
    This would be more along the lines of how the chat box works. When activated/focused, any new keyboard input is sent to the text entry.

Additional context
Additionally there is an issue where the text box does not display the string currently stored inside the hand labeler until the text entry is deselected. This is significantly less of a problem, at least for me.
I suspect if option 1 were implemented, the text entry being deselected by default might resolve this part.
At the same time if option 2 were implemented, I imagine this part would also need to be fixed.

@whatston3
Copy link
Contributor

Fixed in #2897.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants