Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Merging a PR when another PR based on it is opened causes weirdness #14

Open
lleger opened this issue Jan 4, 2018 · 0 comments
Open
Labels

Comments

@lleger
Copy link
Member

lleger commented Jan 4, 2018

Given:
PR #1 is open
PR #2 is open and based on PR #1

When:
PR #1 is merged, Custodian deletes its branch, causing PR #2 to be closed, delabeled, and have its branch deleted.

This is a bug, since PR #2 should still remain open.

Possible fix would be to check for open PRs based on a branch before deleting it. If found, rebase those branches to master instead before deleting. I think the would solve the issue.

@lleger lleger added the bug label Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant