-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High latency when querying thousands of Applications or Application Metrics #548
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. |
This issue has been automatically closed due to a lack of activity for an extended period of time. |
@kminehart Hello! This issue actually went stale, so apologies we didn't get back to you sooner, did you go ahead an open a PR for this change? |
No actually I did not. I started to, and then quickly realized that doing a change like this in a backwards compatible way that doesn't affect existing signatures that people are already using is really difficult. I guess I needed to step away from it for a little bit because I realize now that it's totally doable. I'm not sure I'll have the time to make this change, but what I'd like to see if anyone is willing to pick this up is a function that allows us to control when the next page is requested when listing APM metrics. |
Any chance we could get this reopened? |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. |
Description
In the rest implementation of the
ApplicationsInterface
, and in theAPM
struct, queries that are paginated traverse through every page before returning anything. Users of this package should have the ability to traverse through the pages themselves to avoid high latency requests.This is happening a lot in the Grafana NewRelic datasource.
I'll be opening a pull request soon that ought to maintain backwards compatibility and add functions for retrieving individual pages, if that's ok. :)
The text was updated successfully, but these errors were encountered: