From dfb359f0dbb53e4cbc5106b52c8f3807c7fc8d42 Mon Sep 17 00:00:00 2001 From: Michal Nowacki Date: Mon, 14 Aug 2023 13:29:31 -0400 Subject: [PATCH] ci: make test-pull-request more useful (#711) 1. Don't cancel all in-progress and queued integration tests jobs if one of them fails. 2. Test all pull requests targeting any branch, not only targeting `main`, `dev` and `oapi` branches. 3. There's no need to enable arm64 emulation when not testing arm64 agent. Use the right way to enable arm64. --- .github/workflows/test-agent.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-agent.yml b/.github/workflows/test-agent.yml index a778196fa..5c8b5f611 100644 --- a/.github/workflows/test-agent.yml +++ b/.github/workflows/test-agent.yml @@ -15,11 +15,9 @@ on: branches: - main - 'dev' + # trigger job for each pull request, regardless of the target branch pull_request: - branches: - - main - - 'dev' - - 'oapi' + jobs: daemon-unit-tests: runs-on: ubuntu-latest @@ -96,8 +94,11 @@ jobs: with: path: php-agent - name: Enable arm64 emulation - run: | - docker run --privileged --rm tonistiigi/binfmt --install arm64 + if: ${{ matrix.arch == 'arm64' }} + uses: docker/setup-qemu-action@v2 + with: + image: tonistiigi/binfmt:${{vars.BINFMT_IMAGE_VERSION}} + platforms: arm64 - name: Login to Docker Hub uses: docker/login-action@v2 with: @@ -159,6 +160,7 @@ jobs: needs: [daemon-unit-tests, agent-unit-test] runs-on: ubuntu-latest strategy: + fail-fast: false matrix: platform: [gnu, musl] arch: [amd64, arm64]