-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs site page for Card Composable #822
Comments
Thanks @jannuk59, looking good - a few edits please: Options: Card as a Link
Please indent these three bullets - see the design:
Thanks Janani, have a great weekend! |
@jannuk59 Looks good. Just a few additional comments:
|
@GeriReid @nathanparris is ready for re-review |
thanks @jannuk59, could you please add the word "prop" back in after expand in these two places? So it reads Nathan also suggested in the related components section to only include Grid Layout, instead of the 4 current components. thanks! |
@GeriReid Updated the changes please have a look at it. http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/822-card-composable-doc-site/components/card-composable/ |
Looks good, thanks for the edits @jannuk59 - happy to approve. |
Description
Implement the docs site page based on Design's
Business Benefit/Value
Standard part of new component release
Acceptance Criteria
Should match designs
Design
Illustrations files
Supporting Information
Process/sequence flows, wireframes, third party documentation, tech feasibility, architecture overview/documentation, high level design, data specs etc...
Dependencies
Any known business dependencies or reasons to engage with another team and input into their roadmap/timings
The text was updated successfully, but these errors were encountered: