Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy nytimes/library #1

Open
mattclaw opened this issue Jul 17, 2023 · 2 comments
Open

Deploy nytimes/library #1

mattclaw opened this issue Jul 17, 2023 · 2 comments

Comments

@mattclaw
Copy link

mattclaw commented Jul 17, 2023 •
edited
Loading

Now that support for subpaths has been merged has been merged, we can update the config at .github/workflows/deploy.yml to use the upstream repo for Library instead of our fork.
@mattclaw
Copy link
Author

some notes as i poke around the diff from upstream and from my investigations into broken deploys, things to consider:

  • node version upstream is 18, compared to the current 16
  • pay special attention to the dependency on dotenv as the gcloud app deploy step seems to drop devDeps (is this new behavior?)

@mattclaw
Copy link
Author

mattclaw commented Aug 3, 2023

We'll also want to ensure that additional files added to our fork of library get copied into this customizations repo so that they can be injected into the image within the 'build for GCP' step in the deploy workflow.

Files including:

  • app.yaml
  • more tk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattclaw