Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass changed to pipe #1545

Open
jakwinkler opened this issue Nov 27, 2019 · 3 comments
Open

pass changed to pipe #1545

jakwinkler opened this issue Nov 27, 2019 · 3 comments

Comments

@jakwinkler
Copy link

We've been using an old version (0.7.1) and we had no performance issues.
After decided to upgrade to 0.7.5 we've noticed a performance drop in our Magento 1 installation, after checking all code changes we determine that performance dropped due to change in varnish return from pass to pipe.

Before (0.7.1):

if (!true || req.method !~ "^(GET|HEAD|OPTIONS)$" ||
req.http.Cookie ~ "varnish_bypass=1") {
return (pass);
}

After (0.7.5)

if (!true || req.http.Authorization ||
req.method !~ "^(GET|HEAD|OPTIONS)$" ||
req.http.Cookie ~ "varnish_bypass=1") {
return (pipe);
}

Was that on purpose?

@onlinebizsoft
Copy link

Pipe should be faster than Pass. Pipe means content transferred as soon as received from backend

@jakwinkler
Copy link
Author

@onlinebizsoft ok, I get that, but in our case it actually slowed down the site. Is that possible ?

@onlinebizsoft
Copy link

@qsolutions-pl did you try to change and monitor the website? It shouldn't be that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants