Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Inject {language} variable into URL #835

Closed
yennor opened this issue Jan 7, 2025 · 3 comments · Fixed by #861
Closed

Feature Request: Inject {language} variable into URL #835

yennor opened this issue Jan 7, 2025 · 3 comments · Fixed by #861

Comments

@yennor
Copy link

yennor commented Jan 7, 2025

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

I'd like to be able to inject the language the user uses in nextcloud into an url like:
https://example.com?lang={language}
which could result in
https://example.com?lang=en
https://example.com?lang=fr

etc.
That would be a lot easier, than using the already existing feature of providing a different link for each language.

If it would be accepted I could create a pull request. Should be easy enough to implement.

@yennor
Copy link
Author

yennor commented Feb 7, 2025

@provokateurin Sorry, don't want to annoy you, but would that pull request be accepted?

@provokateurin
Copy link
Member

Yes, the feature makes sense. Are you planning to implement it?

@yennor
Copy link
Author

yennor commented Feb 7, 2025

yes. I should have time next week.

@provokateurin provokateurin linked a pull request Feb 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants