Simplify data management in thermodynamics #725
Assignees
Labels
enhancement
New feature or request
Comments
einola
added a commit
that referenced
this issue
Oct 29, 2024
The temporary damage variable damageUpd was not correctly initialised in PrognosticData::update. This commit just sets it to the value of m_damage (as it should be done), but a proper fix would address issue #725
12 tasks
12 tasks
einola
added a commit
that referenced
this issue
Jan 29, 2025
This is to address issue #725. I removed all duplication of prognostic variables in the model and also removed the slab ice and slab snow thickness variables. The assumption will be that all shared variables are averaged over the grid cell (as is standard), and routines that need the slab thickness calculate this on-the-fly. TODO: Figure out if the tests run (some will not and will need modification. Check if getState and friends are still doing sensible things. Check if we have dangling, unused definitions lying around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PrognosticData holds the main prognostic variables as initial, write-only values, while other model subroutines (e.g., IceGrowth and Dynamics) hold a copy of them as intermediary, read-write values.
There is no need to carry two data versions, which may give rise to unexpected errors.
The text was updated successfully, but these errors were encountered: