Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigned Clade different from Clade of assigned node #1525

Closed
taeschbacher-gilead opened this issue Oct 6, 2024 · 3 comments · Fixed by #1526
Closed

Assigned Clade different from Clade of assigned node #1525

taeschbacher-gilead opened this issue Oct 6, 2024 · 3 comments · Fixed by #1526
Labels
t:bug Type: bug, error, something isn't working

Comments

@taeschbacher-gilead
Copy link

taeschbacher-gilead commented Oct 6, 2024

I queried a RSVA sequence using the nextclade using the web interface.

It seems that the sequence was added to a node with clade A.D.3.3. The clade that was assigned to the sequence is A.D.3. Is this an issue or am I not interpreting this correctly? The sequence is the one at the bottom of the attached figure with name PP352363_L.

rsva_l_nextclade

This is the fasta file:
seq.txt

@taeschbacher-gilead taeschbacher-gilead added good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment t:bug Type: bug, error, something isn't working labels Oct 6, 2024
@rneher
Copy link
Member

rneher commented Oct 7, 2024

Thanks for raising this, @taeschbacher-gilead !

Nextclade first finds the closest match on the fixed reference tree for each sequence and assigns the clade based on this match. Only after all sequences are assigned to clades, the tree is modified by introducing additional internal nodes to improve the placement of the query sequences.

The inconsistency you observe is due to the simplistic way nextclade currently labels newly created internal nodes. It currently uses the clade annotation of the child node of the branch that is being split (A.D.3.3 in this case), even though the sibling (your query sequence) is assigned A.D.3. We are working on ways to make the clade assignment of new internal nodes more consistent.

thanks again for pointing this out!
richard

@taeschbacher-gilead
Copy link
Author

Thank you, Richard, for the fast reply!

@ivan-aksamentov ivan-aksamentov removed needs triage Mark for review and label assignment good first issue Good for newcomers help wanted Extra attention is needed labels Oct 7, 2024
@ivan-aksamentov
Copy link
Member

This has been addressed in #1526 and released in 3.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug Type: bug, error, something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants